move keycloak hook seeder from cli-testing to zenko#2422
Draft
SylvainSenechal wants to merge 1 commit into
Draft
move keycloak hook seeder from cli-testing to zenko#2422SylvainSenechal wants to merge 1 commit into
SylvainSenechal wants to merge 1 commit into
Conversation
SylvainSenechal
commented
May 21, 2026
Contributor
Author
There was a problem hiding this comment.
SylvainSenechal
commented
May 21, 2026
Contributor
Author
There was a problem hiding this comment.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| this.password = parameters.password; | ||
| this.clientId = parameters.clientId; | ||
|
|
||
| logger?.debug('Keycloak parameters', { |
There was a problem hiding this comment.
Debug log leaks the admin password to stdout/CI logs. Redact it.
Suggested change
| logger?.debug('Keycloak parameters', { | |
| logger?.debug('Keycloak parameters', { | |
| host: this.host, | |
| realm: this.realm, | |
| username: this.username, | |
| clientId: this.clientId, | |
| }); |
Contributor
Author
There was a problem hiding this comment.
who cares bro its a ci pipeline, we gon leak 'password'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: ZENKO-5283
Big diff but its a 98% copy of whats in cli-testing
Once this is merged, together with the other pr adding the new method to load parameters directly from within the test, we will be able to do some refactoring around some hard coded values and weird patterns like this one :
to replace it with a proper config