impr: ARSN-563 change error code of RaftSessionLeaderNotConnected to 500#2602
Conversation
The RaftSessionLeaderNotConnected Arsenal error was mapped to HTTP 400 (client error), but "not connected to the leader" is a server-side condition that the client cannot influence. Change it to 500 (server error) so callers can correctly distinguish it from bad-request errors. Also update the description to the more human-readable 'not connected to the RAFT session leader'.
Hello jonathan-gramain,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
|
ping |
|
LGTM — the 400→500 change is correct: "not connected to the leader" is a server-side condition, not a client error. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/8.3/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500 origin/development/8.3
git merge origin/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500
# <intense conflict resolution>
git commit
git push -u origin w/8.3/improvement/ARSN-563-change-RaftSessionLeaderNotConnected-code-to-500The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-563. Goodbye jonathan-gramain. The following options are set: approve |
The RaftSessionLeaderNotConnected Arsenal error was mapped to HTTP 400 (client error), but "not connected to the leader" is a server-side condition that the client cannot influence. Change it to 500 (server error) so callers can correctly distinguish it from bad-request errors.
Also update the description to the more human-readable 'not connected to the RAFT session leader'.