Skip to content

chore(rdb): handle deprecated_optional fields #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mia-Cross merged 2 commits into from
Mar 27, 2026
Merged

chore(rdb): handle deprecated_optional fields #1688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954317b
chore(rdb): handle deprecated_optional fields
estellesoulard Mar 27, 2026
361ae50
Merge branch 'main' into chore/rdb-deprecated-optional
Mia-Cross Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions scaleway-async/scaleway_async/rdb/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ def unmarshal_ACLRule(data: Any) -> ACLRule:
if field is not None:
args["port"] = field
else:
args["port"] = 0
args["port"] = None

return ACLRule(**args)

Expand Down Expand Up @@ -1625,18 +1625,6 @@ def unmarshal_NodeType(data: Any) -> NodeType:
else:
args["memory"] = 0

field = data.get("volume_constraint", None)
if field is not None:
args["volume_constraint"] = unmarshal_NodeTypeVolumeConstraintSizes(field)
else:
args["volume_constraint"] = None

field = data.get("is_bssd_compatible", None)
if field is not None:
args["is_bssd_compatible"] = field
else:
args["is_bssd_compatible"] = False

field = data.get("disabled", None)
if field is not None:
args["disabled"] = field
Expand All @@ -1649,6 +1637,18 @@ def unmarshal_NodeType(data: Any) -> NodeType:
else:
args["beta"] = False

field = data.get("volume_constraint", None)
if field is not None:
args["volume_constraint"] = unmarshal_NodeTypeVolumeConstraintSizes(field)
else:
args["volume_constraint"] = None

field = data.get("is_bssd_compatible", None)
if field is not None:
args["is_bssd_compatible"] = field
else:
args["is_bssd_compatible"] = None

field = data.get("available_volume_types", None)
if field is not None:
args["available_volume_types"] = (
Expand Down
12 changes: 6 additions & 6 deletions scaleway-async/scaleway_async/rdb/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ class ACLRule:
direction: ACLRuleDirection
action: ACLRuleAction
description: str
port: int
port: Optional[int] = None


@dataclass
Expand Down Expand Up @@ -992,11 +992,6 @@ class NodeType:
Quantity of RAM.
"""

is_bssd_compatible: bool
"""
The Node Type is compliant with Block Storage.
"""

disabled: bool
"""
The Node Type is currently disabled.
Expand Down Expand Up @@ -1037,6 +1032,11 @@ class NodeType:
[deprecated] Node Type volume constraints.
"""

is_bssd_compatible: Optional[bool] = None
"""
The Node Type is compliant with Block Storage.
"""


@dataclass
class Privilege:
Expand Down
26 changes: 13 additions & 13 deletions scaleway/scaleway/rdb/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ def unmarshal_ACLRule(data: Any) -> ACLRule:
if field is not None:
args["port"] = field
else:
args["port"] = 0
args["port"] = None

return ACLRule(**args)

Expand Down Expand Up @@ -1625,18 +1625,6 @@ def unmarshal_NodeType(data: Any) -> NodeType:
else:
args["memory"] = 0

field = data.get("volume_constraint", None)
if field is not None:
args["volume_constraint"] = unmarshal_NodeTypeVolumeConstraintSizes(field)
else:
args["volume_constraint"] = None

field = data.get("is_bssd_compatible", None)
if field is not None:
args["is_bssd_compatible"] = field
else:
args["is_bssd_compatible"] = False

field = data.get("disabled", None)
if field is not None:
args["disabled"] = field
Expand All @@ -1649,6 +1637,18 @@ def unmarshal_NodeType(data: Any) -> NodeType:
else:
args["beta"] = False

field = data.get("volume_constraint", None)
if field is not None:
args["volume_constraint"] = unmarshal_NodeTypeVolumeConstraintSizes(field)
else:
args["volume_constraint"] = None

field = data.get("is_bssd_compatible", None)
if field is not None:
args["is_bssd_compatible"] = field
else:
args["is_bssd_compatible"] = None

field = data.get("available_volume_types", None)
if field is not None:
args["available_volume_types"] = (
Expand Down
12 changes: 6 additions & 6 deletions scaleway/scaleway/rdb/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ class ACLRule:
direction: ACLRuleDirection
action: ACLRuleAction
description: str
port: int
port: Optional[int] = None


@dataclass
Expand Down Expand Up @@ -992,11 +992,6 @@ class NodeType:
Quantity of RAM.
"""

is_bssd_compatible: bool
"""
The Node Type is compliant with Block Storage.
"""

disabled: bool
"""
The Node Type is currently disabled.
Expand Down Expand Up @@ -1037,6 +1032,11 @@ class NodeType:
[deprecated] Node Type volume constraints.
"""

is_bssd_compatible: Optional[bool] = None
"""
The Node Type is compliant with Block Storage.
"""


@dataclass
class Privilege:
Expand Down
Loading