Skip to content

chore(k8s): handle deprecated_optional fields #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estellesoulard merged 2 commits into from
Mar 27, 2026
Merged

chore(k8s): handle deprecated_optional fields #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f1c8b9
chore(k8s): handle deprecated_optional fields
estellesoulard Mar 27, 2026
de7e6dc
Merge branch 'main' into chore/k8s-deprecated-optional
Mia-Cross Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scaleway-async/scaleway_async/k8s/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,6 @@ def unmarshal_Cluster(data: Any) -> Cluster:
else:
args["apiserver_cert_sans"] = []

field = data.get("acl_available", None)
if field is not None:
args["acl_available"] = field
else:
args["acl_available"] = False

field = data.get("iam_nodes_group_id", None)
if field is not None:
args["iam_nodes_group_id"] = field
Expand Down Expand Up @@ -514,6 +508,12 @@ def unmarshal_Cluster(data: Any) -> Cluster:
else:
args["commitment_ends_at"] = None

field = data.get("acl_available", None)
if field is not None:
args["acl_available"] = field
else:
args["acl_available"] = None

return Cluster(**args)


Expand Down
10 changes: 5 additions & 5 deletions scaleway-async/scaleway_async/k8s/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,11 +814,6 @@ class Cluster:
Additional Subject Alternative Names for the Kubernetes API server certificate.
"""

acl_available: bool
"""
Defines whether ACL is available on the cluster.
"""

iam_nodes_group_id: str
"""
IAM group that nodes are members of (this field might be empty during early stage of cluster creation).
Expand Down Expand Up @@ -874,6 +869,11 @@ class Cluster:
Date on which it will be possible to switch to a smaller offer.
"""

acl_available: Optional[bool] = None
"""
Defines whether ACL is available on the cluster.
"""


@dataclass
class Node:
Expand Down
12 changes: 6 additions & 6 deletions scaleway/scaleway/k8s/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,6 @@ def unmarshal_Cluster(data: Any) -> Cluster:
else:
args["apiserver_cert_sans"] = []

field = data.get("acl_available", None)
if field is not None:
args["acl_available"] = field
else:
args["acl_available"] = False

field = data.get("iam_nodes_group_id", None)
if field is not None:
args["iam_nodes_group_id"] = field
Expand Down Expand Up @@ -514,6 +508,12 @@ def unmarshal_Cluster(data: Any) -> Cluster:
else:
args["commitment_ends_at"] = None

field = data.get("acl_available", None)
if field is not None:
args["acl_available"] = field
else:
args["acl_available"] = None

return Cluster(**args)


Expand Down
10 changes: 5 additions & 5 deletions scaleway/scaleway/k8s/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,11 +814,6 @@ class Cluster:
Additional Subject Alternative Names for the Kubernetes API server certificate.
"""

acl_available: bool
"""
Defines whether ACL is available on the cluster.
"""

iam_nodes_group_id: str
"""
IAM group that nodes are members of (this field might be empty during early stage of cluster creation).
Expand Down Expand Up @@ -874,6 +869,11 @@ class Cluster:
Date on which it will be possible to switch to a smaller offer.
"""

acl_available: Optional[bool] = None
"""
Defines whether ACL is available on the cluster.
"""


@dataclass
class Node:
Expand Down
Loading