Skip to content

Conversation

@smoreinis
Copy link
Collaborator

Summary

  • Fixes the perpetually pending "Integration Tests Summary" check on PRs that don't modify agentex/** files (like dependabot updates)
  • The required check now always runs and reports success/skip appropriately

Problem

The integration tests workflow only triggered on agentex/** path changes, but "Integration Tests Summary" is a required check in branch protection. This caused PRs like #137 (dependabot bump) to be blocked with a pending check that would never run.

Solution

  • Removed paths filter from pull_request trigger so workflow always starts
  • Added "Detect Changes" job that checks if agentex/ files were modified using git diff
  • Test jobs are conditionally run based on the detection output
  • Summary job always runs to satisfy branch protection, but gracefully reports "skipped" when no relevant changes detected

Test plan

  • This PR itself should pass (no agentex changes, so tests skip)
  • Verify Bump aiohttp from 3.12.15 to 3.13.3 #137 would now pass (can re-run checks after merge)
  • Future agentex PRs should still run full integration tests

@smoreinis smoreinis requested a review from a team as a code owner January 23, 2026 20:51
The "Integration Tests Summary" check is required by branch protection,
but the workflow only triggered on changes to agentex/**. This caused
PRs that only modify other files (like dependency updates) to have a
perpetually pending check.

Changes:
- Remove paths filter from pull_request trigger so workflow always runs
- Add "Detect Changes" job that checks if agentex/ files changed
- Gate test jobs on the changes detection output
- Summary job always runs to satisfy branch protection, but reports
  "skipped" when no agentex changes detected
@smoreinis smoreinis force-pushed the fix/ci-required-check-for-non-agentex-prs branch from 614e088 to cd35835 Compare January 23, 2026 20:53
@smoreinis smoreinis merged commit 651f8cf into main Jan 23, 2026
10 checks passed
@smoreinis smoreinis deleted the fix/ci-required-check-for-non-agentex-prs branch January 23, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants