Skip to content

Fix deployment history test file#297

Merged
declan-scale merged 1 commit intonextfrom
declan-scale/fix-test-file
Mar 30, 2026
Merged

Fix deployment history test file#297
declan-scale merged 1 commit intonextfrom
declan-scale/fix-test-file

Conversation

@declan-scale
Copy link
Copy Markdown
Contributor

@declan-scale declan-scale commented Mar 30, 2026

Greptile Summary

Fixes the import path for assert_matches_type in the deployment history test file, switching from an absolute import (from tests.utils) to a relative import (from ..utils). This aligns the file with the convention used by every other test file under tests/api_resources/.

  • Corrected import style to use relative import, consistent with sibling test files (test_tasks.py, test_agents.py, test_states.py, etc.)
  • No functional changes to test logic; all tests remain skipped via @pytest.mark.skip

Confidence Score: 5/5

This PR is safe to merge — it's a minimal import path fix with no behavioral changes.

The change is a single-line import fix that aligns with the established convention across all sibling test files. No logic, test behavior, or production code is affected.

No files require special attention.

Important Files Changed

Filename Overview
tests/api_resources/test_deployment_history.py Fixes import style from absolute (from tests.utils) to relative (from ..utils), matching the convention used by all other test files in this directory. No functional or logical issues.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["tests/api_resources/test_deployment_history.py"] -->|"from ..utils import assert_matches_type (relative import - AFTER)"| B["tests/utils.py"]
    A -.->|"from tests.utils import assert_matches_type (absolute import - BEFORE)"| B
    C["tests/api_resources/test_tasks.py"] -->|"from ..utils import"| B
    D["tests/api_resources/test_agents.py"] -->|"from ..utils import"| B
    E["tests/api_resources/test_states.py"] -->|"from ..utils import"| B

    style A fill:#d4edda,stroke:#28a745
    style B fill:#cce5ff,stroke:#004085
Loading

Reviews (2): Last reviewed commit: "(chore) fix deployment_history test" | Re-trigger Greptile

@declan-scale declan-scale changed the base branch from main to next March 30, 2026 17:58
@declan-scale declan-scale force-pushed the declan-scale/fix-test-file branch from d7084d3 to 243d68a Compare March 30, 2026 17:59
@declan-scale declan-scale force-pushed the declan-scale/fix-test-file branch from 243d68a to 9a9a333 Compare March 30, 2026 18:01
@declan-scale declan-scale merged commit 8de938b into next Mar 30, 2026
9 checks passed
@declan-scale declan-scale deleted the declan-scale/fix-test-file branch March 30, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant