Skip to content

fix(helm): make Istio metrics plugin optional #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anishharis wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(helm): make Istio metrics plugin optional #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/model-engine/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.7
version: 0.2.8

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
2 changes: 1 addition & 1 deletion charts/model-engine/templates/istio-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if empty .Values.azure }}
{{- if and (empty .Values.azure) .Values.wasmPlugin.enabled }}
apiVersion: telemetry.istio.io/v1alpha1
kind: Telemetry
metadata:
Expand Down
6 changes: 6 additions & 0 deletions charts/model-engine/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ datadog:
# Set per-cluster (e.g. "sgp-dev") so pods report the cluster's real environment.
env: ""

# wasmPlugin controls the Istio attributegen plugin used only to enrich request
# metrics. Disable it in airgapped or TLS-intercepted clusters where the remote
# WASM binary cannot be fetched safely.
wasmPlugin:
enabled: true

spellbook:
enabled: false

Expand Down