linter: add cross-file validation for NOT NULL constraint pattern#957
Open
reteps wants to merge 2 commits intosbdchd:masterfrom
Open
linter: add cross-file validation for NOT NULL constraint pattern#957reteps wants to merge 2 commits intosbdchd:masterfrom
NOT NULL constraint pattern#957reteps wants to merge 2 commits intosbdchd:masterfrom
Conversation
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
reteps
changed the title
NOT NULL constraint pattern
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated with Claude, feel free to use this as a starting point, or I can split this out into an issue.
Generally, I want to be able to track the
NOT NULLconstraints across migration files as our postgres deployments have a transaction-per-file, and so I do the constraint in a different, earlier migration than theSET NOT NULLchange.Summary
ADD CONSTRAINT ... NOT VALIDis in a previous migration file and onlyVALIDATE CONSTRAINT+SET NOT NULLappear in the current fileSET NOT NULLafterVALIDATE CONSTRAINTis not flagged as an error (this was causing me issues in linter: fix adding-not-nullable-field for pg >= 12 with validated CHECK #910 )Follow up to #910
Test plan
pg16_cross_migration_validate_then_set_not_null_oktestpg12_cross_migration_validate_then_set_not_null_oktestpg11_cross_migration_validate_then_set_not_null_errtest (PG 11 correctly rejects)🤖 Generated with Claude Code