Skip to content

Modpack compatibility#133

Merged
budak7273 merged 7 commits intofeat/modpacksfrom
modpack_compatibility
Apr 4, 2026
Merged

Modpack compatibility#133
budak7273 merged 7 commits intofeat/modpacksfrom
modpack_compatibility

Conversation

@rhit-zhangl8
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.40%. Comparing base (ef72bbe) to head (ea89695).
⚠️ Report is 7 commits behind head on feat/modpacks.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                Coverage Diff                @@
##           feat/modpacks     #133      +/-   ##
=================================================
+ Coverage          43.28%   43.40%   +0.11%     
=================================================
  Files                113      113              
  Lines               6288     6292       +4     
=================================================
+ Hits                2722     2731       +9     
+ Misses              3121     3119       -2     
+ Partials             445      442       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@rhit-mooretj rhit-mooretj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is ready to merge. It is a continuation of the existing implementation and I don't see why we leave half finished code sitting in the modpacks branch. The only CI issues is the mise.lock that we've talked about extensively so I see no issues. This code itself looks good, but it's hard to fully evaluate without it being in the grand scheme of things.

@rhit-mooretj rhit-mooretj self-assigned this Apr 2, 2026
@rhit-mooretj rhit-mooretj requested a review from budak7273 April 2, 2026 05:39
@rhit-mooretj rhit-mooretj removed their assignment Apr 2, 2026
@budak7273
Copy link
Copy Markdown
Member

generated actions failing are expected (needs fix from c06b3bc)

@budak7273 budak7273 merged commit 8fe5fb0 into feat/modpacks Apr 4, 2026
20 of 22 checks passed
@budak7273 budak7273 deleted the modpack_compatibility branch April 4, 2026 04:06
@budak7273 budak7273 moved this to ✅ Completed in Rose Senior Project Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Completed

Development

Successfully merging this pull request may close these issues.

3 participants