Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/modpacks #133 +/- ##
=================================================
+ Coverage 43.28% 43.40% +0.11%
=================================================
Files 113 113
Lines 6288 6292 +4
=================================================
+ Hits 2722 2731 +9
+ Misses 3121 3119 -2
+ Partials 445 442 -3 ☔ View full report in Codecov by Sentry. |
rhit-mooretj
left a comment
There was a problem hiding this comment.
I believe this is ready to merge. It is a continuation of the existing implementation and I don't see why we leave half finished code sitting in the modpacks branch. The only CI issues is the mise.lock that we've talked about extensively so I see no issues. This code itself looks good, but it's hard to fully evaluate without it being in the grand scheme of things.
|
|
No description provided.