Implement Modpack-User relationship#131
Conversation
There was a problem hiding this comment.
The timeout was causing problems so I removed it. This could get changed to a larger number, however.
There was a problem hiding this comment.
The purpose of the timeout is to give the containers time to start before running commands that try to contact them. I think docker's --wait just waits for them to start up, not for all of their internals to load. And Vilsol previously added it back after it was removed (84aa93d), so it should probably stay.
What problems was it causing? Error messages/descriptions of behaviors?
There was a problem hiding this comment.
It was timing out before setting up the docker containers
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/modpacks #131 +/- ##
=================================================
+ Coverage 43.40% 43.59% +0.18%
=================================================
Files 113 113
Lines 6292 6375 +83
=================================================
+ Hits 2731 2779 +48
- Misses 3119 3149 +30
- Partials 442 447 +5 ☔ View full report in Codecov by Sentry. |
|
I'm going to bed for the night, but I will fix some of the checks tomorrow. I had an error when starting up from this branch, but I should be able to fix it. At least there was a point that this worked perfectly. |
rhit-zhangl8
left a comment
There was a problem hiding this comment.
tests check for
- Get all modpacks (not user dependent)
- Get a user's modpacks (user dependent)
edge cases: - Get user's modpack returns empty
- Get user's modpack without user token
Looks good to me :)
…oing to compare those through a PR
Changed to keep running tests
removed commented out block of code that survived
File survived error when running atlas
unneeded upon further investigation
This reverts commit ae3cda2.
…26.1.11 and 2026.3.9
…the only ones from the generated lock file
b7f8235 to
410a36d
Compare
|
Commit times are all over the place now from the triple rebase, but history should still be accurate except for the mise lockfile |
I've noticed it takes way longer to run tests now. I will be investigating to see if I messed any code up through the comparision.