Skip to content

Implement Modpack-User relationship#131

Merged
budak7273 merged 38 commits intofeat/modpacksfrom
user-modpacks-working-edits
Apr 4, 2026
Merged

Implement Modpack-User relationship#131
budak7273 merged 38 commits intofeat/modpacksfrom
user-modpacks-working-edits

Conversation

@rhit-mooretj
Copy link
Copy Markdown
Member

I've noticed it takes way longer to run tests now. I will be investigating to see if I messed any code up through the comparision.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout was causing problems so I removed it. This could get changed to a larger number, however.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of the timeout is to give the containers time to start before running commands that try to contact them. I think docker's --wait just waits for them to start up, not for all of their internals to load. And Vilsol previously added it back after it was removed (84aa93d), so it should probably stay.

What problems was it causing? Error messages/descriptions of behaviors?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was timing out before setting up the docker containers

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 46.98795% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.59%. Comparing base (8fe5fb0) to head (410a36d).
⚠️ Report is 38 commits behind head on feat/modpacks.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dataloader/loaders.go 0.00% 14 Missing ⚠️
nodes/user.go 0.00% 13 Missing ⚠️
gql/resolver_users.go 50.00% 7 Missing and 2 partials ⚠️
gql/resolver_modpacks.go 75.75% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           feat/modpacks     #131      +/-   ##
=================================================
+ Coverage          43.40%   43.59%   +0.18%     
=================================================
  Files                113      113              
  Lines               6292     6375      +83     
=================================================
+ Hits                2731     2779      +48     
- Misses              3119     3149      +30     
- Partials             442      447       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhit-mooretj
Copy link
Copy Markdown
Member Author

I'm going to bed for the night, but I will fix some of the checks tomorrow. I had an error when starting up from this branch, but I should be able to fix it. At least there was a point that this worked perfectly.

@rhit-mooretj rhit-mooretj marked this pull request as ready for review April 2, 2026 02:41
Copy link
Copy Markdown

@rhit-zhangl8 rhit-zhangl8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests check for

  • Get all modpacks (not user dependent)
  • Get a user's modpacks (user dependent)
    edge cases:
  • Get user's modpack returns empty
  • Get user's modpack without user token

Looks good to me :)

@budak7273 budak7273 changed the title Adding modpacks to users Implement Modpack-User relationship Apr 4, 2026
Changed to keep running tests
removed commented out block of code that survived
File survived error when running atlas
@budak7273 budak7273 force-pushed the user-modpacks-working-edits branch from b7f8235 to 410a36d Compare April 4, 2026 06:18
@budak7273
Copy link
Copy Markdown
Member

Commit times are all over the place now from the triple rebase, but history should still be accurate except for the mise lockfile

@budak7273 budak7273 merged commit c87e8ae into feat/modpacks Apr 4, 2026
22 checks passed
@budak7273 budak7273 deleted the user-modpacks-working-edits branch April 4, 2026 06:26
@github-project-automation github-project-automation bot moved this from 🆕 Unconfirmed to ✅ Completed in Rose Senior Project Apr 4, 2026
@github-project-automation github-project-automation bot moved this to 🆕 Unconfirmed in Rose Senior Project Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Completed

Development

Successfully merging this pull request may close these issues.

3 participants