Conversation
# Conflicts: # fred/fred_commands/__init__.py
Borketh
left a comment
Borketh
left a comment
There was a problem hiding this comment.
Overall I am not happy with this work. If we want slash commands to work at all, we MUST have feature parity with the text commands. There's a lot missing and a lot done without consulting the code and/or the woman who wrote it for help, and you have blindly relied on AI in places where it was very clearly wrong. Please also look at nextcord documentation. Things like interaction.followup.send incorrectly used instead of interaction.send are small mistakes that nevertheless cause errors and add up quickly.
Also remember to properly type-hint your new code with things like ctx_or_interaction : Context | Interaction
|
Read what I've changed as examples of why I'm not happy and what to do about it. Talk to me on discord about what is needed here if you're not sure. |
…he UX consistent.
Borketh
left a comment
Borketh
left a comment
There was a problem hiding this comment.
Ok so this is a little better, now that I cleaned it up a bit. You ran the black formatter without taking arguments from pyproject.toml, so it made a lot of unnecessary changes for line length that don't follow the project's settings.
This PR is still missing more than half of the commands it's meant to have, because for some reason you opted to remove unused groups instead of implementing them.
fred/fred_commands/_baseclass.py
Outdated
| f"This wouldn't even be a valid command if you did it the right way around!", | ||
| ) | ||
|
|
||
| @slash_command(name="add") |
There was a problem hiding this comment.
Any particular reason why you removed these instead of... implementing them?
There was a problem hiding this comment.
I considered putting a standard parent command format, but no current commands would fall under it, and I had previously discussed with Rob not implementing those to avoid cutting the slash command auto-fill. They can be added back, but unless it's decided to add the corresponding comands they would be dead code currently.
|
|
||
| # Leaderboard Command | ||
| async def leaderboard(self, ctx_or_interaction, ephemeral: bool) -> None: | ||
| async def leaderboard_handler(self, ctx_or_interaction, ephemeral: bool) -> None: |
There was a problem hiding this comment.
When I ran the slash version of the command, it called the "leaderboard" command, but since both were named leaderboard, it would send it twice, so I renamed it to stop that.
3 participants
No description provided.