test(amqp091): join connectionWatcher goroutines in test teardown#109
Open
miotte wants to merge 1 commit into
Open
test(amqp091): join connectionWatcher goroutines in test teardown#109miotte wants to merge 1 commit into
miotte wants to merge 1 commit into
Conversation
Add a sync.WaitGroup to BrokerDetails so the connectionWatcher goroutine started by Connect is joinable, and a stopWatcher test helper that disconnects a client and waits for its watcher to exit. Defer it in every Connect-based test so a watcher can no longer outlive its test and either race the package-level NewAmqpConn091 swap (read in connect()) or panic calling IsClosed() on a stale mock from its 30s fallback branch. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
Summary
sync.WaitGrouptoBrokerDetailsso theconnectionWatchergoroutine started byConnectis joinable (the only production change).stopWatchertest helper that disconnects a client and waits for its watcher to exit, anddeferit in everyConnect-based test so a watcher can no longer outlive its test and either race the package-levelNewAmqpConn091swap (read inconnect()) or panic callingIsClosed()on a stale mock from its 30s fallback branch.clientDisconnect.Load()), so it can't block on a secondshutdownChansend.Test plan
Verified on a branch combining this change with the full race-fix stack (#82, #84, #97, #98, #102, #104):
go test -race -run "Test_Retry|Test_WaitForConnect|Test_connect_connecting_" -count=5 ./internal/provider/connectors/amqp091/...— 12/12 runs pass (was ~75% before this fix).go test -race -run "Test_Retry|Test_WaitForConnect|Test_connect_connecting_|Test_StreamRetry|Test_Disconnect$|Test_SubscribeStream" -count=5 ./internal/provider/connectors/amqp091/...— 6/6 pass (was 0/8 + a 10-minute hang before).go test -race -count=5 ./internal/provider/connectors/amqp091/...— 3/3 pass.go test ./... -race— passes across all packages.go vet ./internal/provider/connectors/amqp091/...andgofmtclean.