Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Python 3 support by bumping node-gyp to 6.1.0#2936

Closed
ext wants to merge 1 commit into
sass:masterfrom
ext:master
Closed

Python 3 support by bumping node-gyp to 6.1.0#2936
ext wants to merge 1 commit into
sass:masterfrom
ext:master

Conversation

@ext

@ext ext commented Jun 23, 2020

Copy link
Copy Markdown

I know similar pull requests have been declined before because it breaks compatibility.

However the current v4 uses node-gyp@3.8.0 which does not support python 3. Python 2 is now end of life since 1 jan 2020 and major distrubutions are starting to drop it (debian, fedora, ubuntu etc). Python 3 support landed in node-gyp@5.0.4.

This is a problem because node-sass will no longer work for new installations where the precompiled binary cannot be used (enterprise firewalls anyone?). So for this user group (myself included) node-sass is effectively unusable right now.

I've already seen that v5 solves this issue but I don't see a timeline and it doesn't seem to be actively worked on. So my suggestion is to either declare this project dead and force users to use a replacement such as dart-sass or merge this or a similar fix.


Since node-gyp@7.0.0 requires node 10 the minimal node version is bumped here as well. This makes sense since node 10 is the current oldest supported version.

EDIT: downgraded to 6.1.0 to support/require node 6 instead of 10.

@cclauss

cclauss commented Jul 2, 2020

Copy link
Copy Markdown

Downgrading to "node-gyp": "^6.1.0", would provide compatibility w Python 2 & 3 and also support Node.js >= v6.

@ext ext changed the title Python 3 support by bumping node-gyp to 7.0.0 Python 3 support by bumping node-gyp to 6.1.0 Jul 5, 2020
@ext

ext commented Jul 5, 2020

Copy link
Copy Markdown
Author

I guess that would make a transition easier, I've updated to PR to use node-gyp@6.1.0 instead.

@adamretter

Copy link
Copy Markdown

I would like to add a +1 to this PR. We are having problems using node-sass on newer platforms that provide Python3

@cclauss

cclauss commented Jul 20, 2020

Copy link
Copy Markdown

@adamretter Please view the Files changed and then click the Review changes green button at the top right of that page and then click Approve.

Positive reviews give project maintainers confidence that these changes are in the best interests of the project.

@surfaceowl

Copy link
Copy Markdown

+1 for this. please include in the next merge

@cclauss

cclauss commented Jul 22, 2020

Copy link
Copy Markdown

@surfaceowl Please view the Files changed and then click the Review changes green button at the top right of that page and then click Approve.

Positive reviews give project maintainers confidence that these changes are in the best interests of the project.

@keithslater

Copy link
Copy Markdown

Any reason this hasn't been merged?

@cclauss

cclauss commented Aug 8, 2020

Copy link
Copy Markdown

@keithslater Please do the following #2936 (comment)

@ext

ext commented Aug 8, 2020

Copy link
Copy Markdown
Author

Any reason this hasn't been merged?

It seems like the maintainers are moving towards deprecating node-sass and libsass in favor of dart-sass, see #2952.

@liudonghua123 liudonghua123 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

BREAKING CHANGE: requires at least node 6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants