Fix KeybindingsToast browser fixture to include commandCode#5
Merged
Conversation
The ServerSettingsSchema in packages/contracts/src/settings.ts already requires `commandCode` in `providers` (it landed in "Add Command Code provider" — 2080dba), but the test fixture in apps/web/src/components/KeybindingsToast.browser.tsx was never updated to match. With strict TS, that produced: src/components/KeybindingsToast.browser.tsx(146,7): error TS2741: Property 'commandCode' is missing in type ... but required in type ... and broke the Check job in CI. Add the missing commandCode block to the fixture, matching the defaults declared on CommandCodeSettings (enabled=true, skipOnboarding=true, maxTurns=25, printTimeoutMs=180_000). Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the typecheck failure on
main:The
ServerSettingsSchema.providersstruct inpackages/contracts/src/settings.tsrequirescommandCode(added in 2080dba "Add Command Code provider"), but the test fixture inapps/web/src/components/KeybindingsToast.browser.tsxwas never updated to match, so the strict typecheck in the Check job fails.This PR adds the missing
commandCodeblock to the fixture, using the same defaults declared onCommandCodeSettings(enabled=true, skipOnboarding=true, maxTurns=25, printTimeoutMs=180_000).