Skip to content

Custom icons on iOS#2022

Closed
samuelclay wants to merge 2 commits intodejal-alphafrom
ios-custom-icons
Closed

Custom icons on iOS#2022
samuelclay wants to merge 2 commits intodejal-alphafrom
ios-custom-icons

Conversation

@samuelclay
Copy link
Copy Markdown
Owner

@samuelclay samuelclay commented Jan 7, 2026

This PR only shows the custom icons, but it shows them everywhere they are displayed (feed list, story titles list, etc).

@samuelclay samuelclay requested a review from Dejal January 7, 2026 23:28
@Dejal
Copy link
Copy Markdown
Collaborator

Dejal commented Jan 8, 2026

Is there an easy way to merge/pull this into my local repo working copy, so I can test it?

Also, if you're going to add functionality to the iOS/Mac app, I recommend getting Claude to use Swift. Live in the now!

@samuelclay
Copy link
Copy Markdown
Owner Author

That's a fair point on Obj-C, but these are existing files and converting those is a huge task that we don't need to do yet. Maybe we rewrite each view piecemeal one day this year.

As for your local repo, you should be able to handle that by pulling this branch and merging it locally.

@Dejal
Copy link
Copy Markdown
Collaborator

Dejal commented Jan 8, 2026

I don't mean rewriting the existing view; I agree that's a bad idea. (I have Swift wrappers for new code where appropriate). But when writing a new class (like CustomIconRenderer in this example), it should be done in Swift. I assume Claude can be instructed to write new classes in Swift but update existing ones as-is.

I took a look at the code, but there are several conflicts, including with MainInterface.storyboard, which is too difficult to merge. Can you please use the dejal-alpha branch for iOS changes. It has extensive changes from the main and dejal branches, and all new work should be done there.

@samuelclay
Copy link
Copy Markdown
Owner Author

You bet, I'll make those changes and merge it in. You know I'm not doing either manually, the obj-c to swift rewrite will be trivial, and the dejal-alpha merge often requires no input. I'll sometimes ask Claude to use the AskUserQuestion tool to decide merge conflicts, but it can accumulate its own context better than I can.

@samuelclay samuelclay changed the base branch from main to dejal-alpha January 8, 2026 17:32
- CustomIconRenderer.swift renders preset icons, emojis, and colors
- Updated FeedChooserItem, FeedChooserTitleView, FolderTitleView for icons
- Added heroicons-solid and lucide icon assets
- Backend API already supports this via flat feeds endpoint

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@samuelclay
Copy link
Copy Markdown
Owner Author

Ok, its now a clean PR on dejal-alpha
Read All the Stories

- Fix crash when stillVisibleFeeds contains boolean instead of NSIndexPath
  (pre-existing bug exposed by custom icons feature)
- Add custom feed icon support to story detail header for both river view
  and single feed view
- Add custom feed icon support to feed detail header (story list view)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@samuelclay
Copy link
Copy Markdown
Owner Author

Closing in lieu of #2024, which has a bunch more (and more coming) iOS 26 changes to be merged into dejal-alpha

@samuelclay samuelclay closed this Jan 8, 2026
@samuelclay samuelclay deleted the ios-custom-icons branch February 2, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants