Skip to content

Make reglist_sort_() stable #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pd3 merged 1 commit into from
Jul 6, 2026
Merged

Make reglist_sort_() stable #2575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion regidx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,14 @@ static int cmp_reg_ptrs(const void *a, const void *b)
}
static int cmp_reg_ptrs2(const void *a, const void *b)
{
return cmp_regs(*((reg_t**)a),*((reg_t**)b));
reg_t **ra = (reg_t**) a;
reg_t **rb = (reg_t**) b;
int res = cmp_regs(*ra, *rb);
// Ensure sort is stable by comparing pointers. This is safe as we're
// sorting a list of pointers to the original regions rather than the
// regions themselves. As they all point into the same array, they
// can be safely compared and also preserve the original ordering.
return res ? res : (*ra > *rb) - (*ra < *rb);
}

inline int regidx_push(regidx_t *idx, char *chr_beg, char *chr_end, uint32_t beg, uint32_t end, void *payload)
Expand Down
Loading