Add code formatting toolchain and apply consistently#139
Merged
Conversation
- Add cmake-format (v0.6.13) and clang-format to pre-commit; exclude external_libraries/ - Disable clang-format for JavaScript in .clang-format - Add pre-commit job to CI, wired into all-passed gate - Remove PNaCl test harness (tests/pnacl/, examples/common/) - Remove duplicate tinydir from examples/sampler/libs/; Xcode projects now reference external_libraries/tinydir - Apply clang-format, cmake-format, and black to all project files
- Run pre-commit install to register git hooks in local working copy - Disable clang-format for JSON (conflicts with pretty-format-json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmake-formatandclang-formatto pre-commit config; excludeexternal_libraries/globally; disable clang-format for JavaScriptpre-commitCI job (usingpre-commit/action) wired into theall-passedgatetests/pnacl/,examples/common/)tinydircopy fromexamples/sampler/libs/; Xcode projects now referenceexternal_libraries/tinydirTest plan