[Dummy PR to validate the failing test for Photon os]Add timeout parameter to network.traceroute to prevent CI flakes#68844
Open
sujitdb wants to merge 1 commit intosaltstack:masterfrom
Conversation
The traceroute command can hang indefinitely in environments with restricted network access (e.g., GitHub Actions runners on Azure) where ICMP/UDP probe packets are blocked, causing each hop to wait the full default timeout (5s × 3 probes × 30 hops = ~150s). This adds an optional `timeout` parameter to `network.traceroute()` that is passed through to `cmd.run`, and uses it in the functional test with a 60-second limit to prevent the >90s pytest timeout. Made-with: Cursor
sujitdb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutparameter tonetwork.traceroute()to prevent the command from hanging indefinitely in restricted network environmentstest_network_traceroutenow usestimeout=60to prevent >90s pytest timeouts on CI runners (Photon OS 5, etc.)Root Cause
The
traceroutecommand hangs when ICMP/UDP packets are blocked (e.g., GitHub Actions runners on Azure), causing 30 hops × 5s × 3 probes = ~150s, exceeding the 90s pytest timeout.Test plan