Open
Conversation
This is not strictly necessary in 3008+ because of changes to the `state.running` function, but it's still more correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes several issues in the new
ssh_pkimodules.Since they have never been released, I did not create bug reports/include changelog entries. I still added tests ofc.
What issues does this PR fix or reference?
No bug reports, only present in master
Previous Behavior
ssh_pki.create_private_keydoes not write pubkey as advertizedssh_pki.certificate_manageddoes not respectcopypathssh_pki.certificate_managedcrashes whensigning_private_keyis hardcoded in the policy (analog to [3006.x] Fix x509_v2 local signing with signing policy #66416)ssh_pki.certificate_managed_wrapperincorrectly passes arguments forfile.managednot_afterallows to exceed a policy'smax_ttl(this is a critical bug)New Behavior
ssh_pki.create_private_keywrites pubkey as advertizedssh_pki.certificate_managedrespectscopypathssh_pki.certificate_managedworks correctly whensigning_private_keyis hardcoded in the policyssh_pki.certificate_managed_wrappercorrectly passes arguments forfile.managednot_afterdoes not allow to exceed a policy'smax_ttlMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes