Skip to content

Docs: note that service.masked may require service.disabled first (#61322)#68836

Open
kimimgo wants to merge 1 commit intosaltstack:masterfrom
kimimgo:fix/docs-service-masked-61322
Open

Docs: note that service.masked may require service.disabled first (#61322)#68836
kimimgo wants to merge 1 commit intosaltstack:masterfrom
kimimgo:fix/docs-service-masked-61322

Conversation

@kimimgo
Copy link
Copy Markdown

@kimimgo kimimgo commented Mar 20, 2026

Fixes #61322

Add a note to the service.masked docstring advising users to
disable the service before masking it, as masking an enabled
service can result in a systemd error.

…ltstack#61322)

Add a note to the service.masked docstring advising users to
disable the service before masking it, as masking an enabled
service can result in a systemd error.
@kimimgo kimimgo requested a review from a team as a code owner March 20, 2026 13:18
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 20, 2026

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We're glad you've joined our community and look forward to doing awesome things with you!

@frebib
Copy link
Copy Markdown
Contributor

frebib commented Mar 20, 2026

Sounds like a code bug that should be fixed. I'm not sure papering over it with documentation is a good "fix" here

@kimimgo
Copy link
Copy Markdown
Author

kimimgo commented Mar 21, 2026

@frebib Good point — you're right that systemctl mask itself handles enabled services without error (it overwrites the symlink). The fact that Salt fails here suggests it's checking for the existing symlink before calling systemctl mask, which is overly strict.

Looking at it again, the proper fix would be in the Salt service module code rather than documentation. I'll update this PR to investigate the actual code path, or close it if a code fix is more appropriate.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] service.masked should mention service.disabled

2 participants