Add force color option for Salt outputters#237
Open
Sxderp wants to merge 2 commits intosaltstack:developfrom
Open
Add force color option for Salt outputters#237Sxderp wants to merge 2 commits intosaltstack:developfrom
Sxderp wants to merge 2 commits intosaltstack:developfrom
Conversation
The salt CLI commands offer an option to force color output. An option on the Pepper CLI now offers the equivalent feature.
Author
|
@barneysowood is there any activity in this repo? Hopefully this simple change can get merged. |
barneysowood
requested changes
Mar 19, 2025
Collaborator
barneysowood
left a comment
barneysowood
left a comment
There was a problem hiding this comment.
@Sxderp - thanks for submitting this PR. I'm just getting back to working on this again, apologies for the delay.
This is good and with some slight changes, I'd be happy to merge. I would ideally like to see a test, but if you aren't easily able to do that, no problem - I can pick that up later.
Thanks!
| '--output-force-color', dest='output_force_color', default=False, action='store_true', | ||
| help=textwrap.dedent(''' | ||
| Force salt outputter to use color when printing. | ||
| ''') |
Collaborator
There was a problem hiding this comment.
I'd like to have options match the salt command where possible:
--force-color, --force-colour
Force colored output.Would you be OK with updating that to support --force-color and --force-colour?
If so, probably best to also update the var to force_color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The salt CLI commands offer an option to force color output. An option on the Pepper CLI now offers the equivalent feature.