Fix git dependencies with salt 3005.5+ and 3006.6+#349
Open
sblaisot wants to merge 1 commit intosaltstack:masterfrom
Open
Fix git dependencies with salt 3005.5+ and 3006.6+#349sblaisot wants to merge 1 commit intosaltstack:masterfrom
sblaisot wants to merge 1 commit intosaltstack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salt 3005.5 and salt 3006.6 introduced a fix for a CVE that refuse to serve files outside of files_root
When using git dependencies, they are cloned outside of files_root and we used to make a symlink from files_root to the dependencies formulas.
This pull request replace the symlink witth a hard copy of the dependencies inside files_root to make dependencies work under salt 3005.5+ and 306.6+
This fixes #348