retry via connector when rate limit sleep follows manual exceed#29
Open
JonPurvis wants to merge 2 commits intosaloonphp:v2from
Open
retry via connector when rate limit sleep follows manual exceed#29JonPurvis wants to merge 2 commits intosaloonphp:v2from
JonPurvis wants to merge 2 commits intosaloonphp:v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes saloonphp/saloon#532
When
HasRateLimitsis applied to a Request (not a Connector), a 429 handled withgetTooManyAttemptsLimiter()->sleep()triggers a retry that called$this->send().send()exists on Connector, not Request, so the retry fails (e.g. BadMethodCallException via Macroable, or an undefined-method error depending on context).This PR introduces some changes:
Retry using
$response->getConnector()->send($response->getRequest())so the retry always goes through the connector.Use
$limitThatWasExceeded->getShouldSleep()instead of the loop’s last$limitwhen deciding whether to throw vs sleep/retry.