Skip to content

fix: fail immediately when --url is unreachable instead of 60s timeout @W-21331028@ #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepu-mungamuri94 merged 1 commit into from
Mar 4, 2026
Merged

fix: fail immediately when --url is unreachable instead of 60s timeout @W-21331028@ #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions messages/webapp.dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ Failed to watch manifest: %s
Dev server unreachable at %s.
Start your dev server manually at that URL, or add dev.command to webapplication.json to start it automatically.

# error.dev-url-unreachable-with-flag

Dev server unreachable at %s.
Remove --url to use dev.command to start the server automatically, or ensure your dev server is running at that URL.

# error.port-in-use

Port %s is already in use. Try specifying a different port with the --port flag or stopping the service that's using the port.
Expand Down
11 changes: 9 additions & 2 deletions src/commands/webapp/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,15 @@ export default class WebappDev extends SfCommand<WebAppDevResult> {
devServerUrl = resolvedUrl;
this.log(messages.getMessage('info.url-already-available', [resolvedUrl]));
this.logger.debug(`URL ${resolvedUrl} is reachable, skipping dev server startup`);
} else if ((flags.url ?? manifest?.dev?.url) && !manifest?.dev?.command?.trim()) {
// Explicit URL (--url or dev.url) but no dev.command - don't start (we can't control the port)
} else if (flags.url) {
// User explicitly passed --url; assume server is already running at that URL
// Fail immediately if unreachable (don't start dev server)
throw new SfError(messages.getMessage('error.dev-url-unreachable-with-flag', [resolvedUrl]), 'DevServerUrlError', [
`Ensure your dev server is running at ${resolvedUrl}`,
'Remove --url to use dev.command to start the server automatically',
]);
} else if (manifest?.dev?.url && !manifest?.dev?.command?.trim()) {
// dev.url in manifest but no dev.command - don't start (we can't control the port)
throw new SfError(messages.getMessage('error.dev-url-unreachable', [resolvedUrl]), 'DevServerUrlError', [
`Ensure your dev server is running at ${resolvedUrl}`,
'Or add dev.command to webapplication.json to start it automatically',
Expand Down