-
Notifications
You must be signed in to change notification settings - Fork 19
feat: use the right LWC/Dev server version for the org @W-20405334@ #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
4e42a9d
feat: use the right LWC/Dev server version for the org
abdulsattar 5438fb3
fix: tests
abdulsattar cffc588
fix: remove check-versions script
abdulsattar 1fc902c
fix: types
abdulsattar 7b6cde7
fix: simplify versionresolver
abdulsattar 86efeb1
fix: simplify dependency loader
abdulsattar fc024f4
fix: remove duplication
abdulsattar 0fcd4af
fix: remove deprecated ensureMatchingAPIVersion
abdulsattar 2637a87
refactor: simplify VersionResolver and DependencyLoader and improve e…
abdulsattar ea20586
feat: implement dual version support via NPM aliasing and dynamic loa…
abdulsattar 526a576
fix: use new package that has no peerDependencies
abdulsattar d64c50a
fix: use the right version for 260
abdulsattar 6b0b6f0
chore(release): 6.0.2-canary.0 [skip ci]
svc-cli-bot cc32204
fix: use latest lwc
abdulsattar 3e7c086
fix: enable TypeScript dependency check in CI workflow
nrkruk 756f84c
fix: use new lwc for 260
abdulsattar de78971
chore(release): 6.0.2-canary.1 [skip ci]
svc-cli-bot ba3ba9a
fix: add back 258
abdulsattar abb3e5e
fix: add test to check versions
abdulsattar b27c5ef
fix: remove DUAL_VERSION.md
abdulsattar 8173b8d
fix: remove unused env var
abdulsattar 412780f
fix: feedback
abdulsattar c58238c
fix: yarn install
abdulsattar 1ebfe92
Merge remote-tracking branch 'origin/main' into abdulsattar/dual-version
abdulsattar 4a4346d
fix: cleanup
abdulsattar 4b5df0f
fix: stuff
abdulsattar 70df2f8
fix: bump 66.0 to 13.2.23 for removing typescript
abdulsattar 552ad0d
fix: fix 66.0 version
abdulsattar 246c67d
chore(release): 6.1.1-canary.0 [skip ci]
svc-cli-bot a8a737e
fix: remove 65.0 and use canary 66.0, 67.0
abdulsattar f3675a7
fix: feedback
abdulsattar f621699
fix: yarn install
abdulsattar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,4 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| # Run the custom version check script | ||
| node .husky/check-versions.js | ||
|
|
||
| yarn lint && yarn pretty-quick --staged | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a test to prevent dependabot from updating dependencies beyond the approved range of each version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify if dependabot acutaly updates aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document api versioning with wlc-dev-server. if (version === "262") { }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI updates to the latest plugin always. Change teh frequency if it's too often and the bundle size too big.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nick: reduce the bundle size instead.