fix: make rules_java available in rules_spring for Bazel 9.0#282
fix: make rules_java available in rules_spring for Bazel 9.0#282yakovliam wants to merge 1 commit intosalesforce:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @yakovliam to sign the Salesforce Inc. Contributor License Agreement. |
|
Just a note: I didn’t focus much on project conventions or code style in this PR – the main goal was to get |
|
Thanks. This is making my release decisions easier. There were backwards incompat changes made to our deps_filter utility (not really the main feature of rules_spring, but reachable in Starlark) so I was debating what to do. Having this included makes me want to just jump to 3.0.0 and be honest about back compat. This is a big enough feature (Bazel 9) to warrant a major. |
Let me know if there's more I can do to help this along. Additionally, I'm not sure why the CLA is failing; I did sign it. |
|
Any planned release date for this change? |
Summary
This PR updates
rules_springto be compatible with Bazel 9 / Bzlmod by makingrules_javaproperly available across the project. Previously, many.bzlfiles (includingspringboot.bzl) failed to build due to missing Java symbols likeJavaInfoandjava_binary.With Bazel 9, Bzlmod changes the way dependencies are loaded at runtime: library-specific Starlark symbols are no longer implicitly available. Downstream users would encounter errors unless
rules_javawas manually included. This PR resolves that by declaringrules_javaas a dependency inMODULE.bazeland updating the relevant.bzlfiles to explicitly load the required symbols.Changes
rules_javatoMODULE.bazelso that Java toolchains and symbols are available project-wide..bzlfiles to load the necessary Java symbols (JavaInfo,java_binary) where they are used.Motivation / Problem
Without this change:
Notes
This PR will need some work from project maintainers to be ready to merge.