This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Use OrderedMap to maintain YML input file props order.#201
Open
tomger wants to merge 1 commit intosalesforce-ux:masterfrom
Open
Use OrderedMap to maintain YML input file props order.#201tomger wants to merge 1 commit intosalesforce-ux:masterfrom
tomger wants to merge 1 commit intosalesforce-ux:masterfrom
Conversation
|
@tomger, the failing test just needs a done() in the r func: lib/tests/effects.js, line 103.
worked for me, anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our token setup the order of the YML props has a meaning. e.g. colors are grouped by hue.
As far as I can tell without this patch the order of the output is nondeterministic/scrambled. This is because Immutable.fromJS, at least in our case, converts the input JS array into a non-ordered Map instead of an OrderedMap.
Example.yml
Example.output (without patch)
Example.output (with patch)