Move from ethereum-blockies-base64 to blo#2555
Merged
katspaugh merged 1 commit intosafe-global:devfrom Sep 27, 2023
Merged
Conversation
katspaugh
approved these changes
Sep 26, 2023
Member
katspaugh
left a comment
katspaugh
left a comment
There was a problem hiding this comment.
Hey Pierre, that’s awesome! Thanks so much!
Contributor
Author
|
@katspaugh you’re welcome, thanks for the quick review! 🤗 |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
Makes the generation of identicons faster and more precise, while reducing the bundle size.
Disclaimer: I am the author of blo.
How this PR fixes it
By moving to blo.
How to test it
Run the app and check anywhere the
Identiconcomponent gets rendered. See also this other PR: 5afe/safe-react-components#229Screenshots
Before:
After:
Before (zoomed in):
After (zoomed in):
Checklist