Skip to content

Avoid creating new socket every time on connectAsync#40

Open
angelix wants to merge 3 commits into
sacOO7:masterfrom
aveworks:fix-creating-sockets
Open

Avoid creating new socket every time on connectAsync#40
angelix wants to merge 3 commits into
sacOO7:masterfrom
aveworks:fix-creating-sockets

Conversation

@angelix

@angelix angelix commented Aug 19, 2018

Copy link
Copy Markdown
Contributor

For every call to connect/connectAsync there is a new ws socket created, leaving the previous one connected but orphaned.
This PR, allow only one instance of Socket to be actively connected at any time.

@sacOO7

sacOO7 commented Aug 19, 2018

Copy link
Copy Markdown
Owner

Hi @angelix , I am not sure if it creates new connection everytime.... I am sure, it will close the previous socket (The reason why new one is created). Still, will look into it. Thank you for the PR.

@angelix

angelix commented Aug 19, 2018

Copy link
Copy Markdown
Contributor Author

My server had a new connection for every connectAsync from the client.
If you take a look at the code, it just replace ws with new Socket every time.
Thanks @sacOO7

@sacOO7

sacOO7 commented Aug 21, 2018

Copy link
Copy Markdown
Owner

Hey, will be looking into it. Little busy those days ...

@angelix

angelix commented Sep 15, 2018

Copy link
Copy Markdown
Contributor Author

Did you have the time to test this @sacOO7 ? Thanks

@angelix

angelix commented Oct 5, 2018

Copy link
Copy Markdown
Contributor Author

Hi @sacOO7 ,
When can you release a new version of the lib with the fixes?
Thanks

1 similar comment
@angelix

angelix commented Jan 6, 2019

Copy link
Copy Markdown
Contributor Author

Hi @sacOO7 ,
When can you release a new version of the lib with the fixes?
Thanks

@angelix

angelix commented Apr 18, 2019

Copy link
Copy Markdown
Contributor Author

Hi @sacOO7
It's being over 6 months for this PR to get merged or release a new version.
Do you need any help?

@angelix

angelix commented Aug 20, 2019

Copy link
Copy Markdown
Contributor Author

@sacOO7 ? :(

@sacOO7

sacOO7 commented Apr 10, 2020

Copy link
Copy Markdown
Owner

Hey @angelix , will be looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants