-
-
Notifications
You must be signed in to change notification settings - Fork 595
add xiaomi.airp.va2b support #1940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 8 commits
82bbf8d
74ee5e2
fcdfa87
381a1e1
9b5efaa
c5f04a0
4d2310e
d0cf68b
4d23d25
6cf9755
469249e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -558,7 +558,6 @@ def status(self) -> RoidmiVacuumStatus: | |
| return RoidmiVacuumStatus( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this comment should be removed, since the
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that's probably just due to some copy&pasting. Please remove changes to roidmivacuum_miot from this PR (as they are unrelated, but feel free to create a separate PR to remove those if you wish!) and then this is good to go 👍 |
||
| for prop in self.get_properties_for_mapping() | ||
| } | ||
| ) | ||
|
|
@@ -569,7 +568,6 @@ def consumable_status(self) -> RoidmiConsumableStatus: | |
| return RoidmiConsumableStatus( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
|
dsh0416 marked this conversation as resolved.
|
||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here. |
||
| for prop in self.get_properties_for_mapping() | ||
| } | ||
| ) | ||
|
|
@@ -580,7 +578,6 @@ def cleaning_summary(self) -> RoidmiCleaningSummary: | |
| return RoidmiCleaningSummary( | ||
| { | ||
| prop["did"]: prop["value"] if prop["code"] == 0 else None | ||
|
dsh0416 marked this conversation as resolved.
|
||
| # max_properties limmit to 10 to avoid "Checksum error" messages from the device. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and same here. |
||
| for prop in self.get_properties_for_mapping() | ||
| } | ||
| ) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.