refactor: unify validation layer and shared types#2778
Merged
ryanfowler merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
Replace 20 near-identical validation wrapper functions with a single resolveField function that handles both lenient (server) and fail-fast (pipeline) modes via ParseContext. Extract shared parseTransformOptions, parseMetadataFlags, and validateFormat functions used by both server and pipeline. Consolidate three duplicate TransformOptions type definitions into one. Merge identical AVIF/HEIC preset objects. ~300 lines of boilerplate removed, ~50 lines of shared code added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 20 near-identical validation wrapper functions with a single resolveField function that handles both lenient (server) and fail-fast (pipeline) modes via ParseContext. Extract shared parseTransformOptions, parseMetadataFlags, and validateFormat functions used by both server and pipeline. Consolidate three duplicate TransformOptions type definitions into one. Merge identical AVIF/HEIC preset objects.
~300 lines of boilerplate removed, ~50 lines of shared code added.