fix: correctness bugs, security hardening, and code cleanup#2777
Merged
ryanfowler merged 1 commit intomainfrom Feb 10, 2026
Merged
fix: correctness bugs, security hardening, and code cleanup#2777ryanfowler merged 1 commit intomainfrom
ryanfowler merged 1 commit intomainfrom
Conversation
Owner
ryanfowler
commented
Feb 10, 2026
ryanfowler
commented
- Use ?? instead of || in applyFormat() so effort=0 is not silently replaced by the preset default
- Return 502 instead of 400 for upstream-caused fetch errors (too many redirects, no body, unable to make request)
- Validate user-supplied content-type in pipeline S3 uploads to prevent stored XSS via types like text/html
- Replace ACL type hack with conditional spread in s3.ts
- Remove dead commented-out format detection code (BMP, ICO, PSD, HEIF)
- Document DNS rebinding TOCTOU limitation in fetch.ts
- Use ?? instead of || in applyFormat() so effort=0 is not silently replaced by the preset default - Return 502 instead of 400 for upstream-caused fetch errors (too many redirects, no body, unable to make request) - Validate user-supplied content-type in pipeline S3 uploads to prevent stored XSS via types like text/html - Replace ACL type hack with conditional spread in s3.ts - Remove dead commented-out format detection code (BMP, ICO, PSD, HEIF) - Document DNS rebinding TOCTOU limitation in fetch.ts
ryanfowler
force-pushed
the
fix/bugs-security-cleanup
branch
from
ea1978e to
3c2cc74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.