fix(sensing): reduce empty-room adaptive false positives#527
Closed
davestanyer wants to merge 1 commit into
Closed
fix(sensing): reduce empty-room adaptive false positives#527davestanyer wants to merge 1 commit into
davestanyer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
absent/person_count: 0.Why
In the current empty-room acceptance case, all six live ESP32 CSI nodes could report
present_movingwhile the independent person-count path reported zero people. That creates an empty-room false positive. This PR treats that contradiction as absence unless the independent person-count/fusion path agrees there is a person.Related: #518, #521
Local validation
cargo fmt --package wifi-densepose-sensing-servercargo test -p wifi-densepose-sensing-server --bin sensing-server adaptive_classifier::tests -- --nocapture— 4 passedcargo test -p wifi-densepose-sensing-server --bin sensing-server -- --nocapture— 74 passedcargo test -p wifi-densepose-sensing-server— passeddocker compose -f docker/docker-compose.yml up -d --build sensing-server— rebuilt/restarted/api/v1/sensing/latestreportedmotion_level: absent,presence: false,estimated_persons: null; final/api/v1/nodessample showed all six active nodes asabsentwithperson_count: 0.Notes
This is intentionally focused on sensing-server adaptive/runtime behavior. It does not include local recordings, generated model files, firmware binaries, or unrelated local worktree changes.