Update docker-entrypoint.sh#1370
Open
BOT9315 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuView sensing-server entrypoint - hardened version
Fixes ruvnet/RuView issue #864:
Original behavior started the server with --bind-addr 0.0.0.0 always,
regardless of whether RUVIEW_API_TOKEN was set, meaning the default
Docker path exposed live sensing/pose data with auth silently OFF.
This version:
1. Refuses to start bound to a non-loopback address unless
RUVIEW_API_TOKEN is set AND RUVIEW_LAN_MODE=1 is explicitly passed
(fail-closed instead of fail-open).
2. Defaults RUVIEW_BIND_ADDR to 127.0.0.1 instead of 0.0.0.0.
3. Logs the actual auth/bind posture loudly on startup so it's obvious
what mode you're running in (matches the log lines referenced in
the original bug report, kept for compatibility with tooling that
parses them).