Update docker-compose.yml#1369
Open
BOT9315 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It publishes ports 3000:3000, 3001:3001, and 5005:5005/udp GitHub
The entrypoint starts the server with --bind-addr 0.0.0.0, --http-port 3000, --ws-port 3001
When RUVIEW_API_TOKEN is empty, /api/v1/* auth is a no-op, and /ws/sensing is unauthenticated even when a token IS set
The suggested fix is to fail startup when binding to 0.0.0.0 or publishing ports without a non-empty token, and to bind to loopback by default, requiring an explicit unsafe/LAN flag to expose it wider
A separate audit also flagged missing resource limits (no mem_limit/cpus/pids_limit) and no read_only filesystem restriction on the same file