fix(ruvector): make createEmbedder() init WASM correctly under Node (…#533
Open
as473 wants to merge 1 commit into
Open
fix(ruvector): make createEmbedder() init WASM correctly under Node (…#533as473 wants to merge 1 commit into
as473 wants to merge 1 commit into
Conversation
…uvnet#523) The bundler-target wasm-pack wrapper (pkg/ruvector_onnx_embeddings_wasm.js) starts with `import * as wasm from "...bg.wasm"` (unresolvable in plain Node ESM) and exports no `default` init, so createEmbedder()'s old `import(wrapper); await default()` path threw `m.default is not a function` under Node. Mirror the proven worker init (embed-worker.mjs): import the _bg.js glue directly and instantiate the .wasm via WebAssembly.instantiate, Node-guarded. The browser/bundler default() path is preserved. Vectors are identical to the worker path by construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#523)
The bundler-target wasm-pack wrapper (pkg/ruvector_onnx_embeddings_wasm.js) starts with
import * as wasm from "...bg.wasm"(unresolvable in plain Node ESM) and exports nodefaultinit, so createEmbedder()'s oldimport(wrapper); await default()path threwm.default is not a functionunder Node.Mirror the proven worker init (embed-worker.mjs): import the _bg.js glue directly and instantiate the .wasm via WebAssembly.instantiate, Node-guarded. The browser/bundler default() path is preserved. Vectors are identical to the worker path by construction.