Skip to content

Fix pod deletion policy reconciliation#179

Merged
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/node-down-pod-deletion-reconcile
Jul 11, 2026
Merged

Fix pod deletion policy reconciliation#179
GatewayJ merged 1 commit into
rustfs:mainfrom
GatewayJ:fix/node-down-pod-deletion-reconcile

Conversation

@GatewayJ

Copy link
Copy Markdown
Member

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Fixes #55

Summary of Changes

This PR tightens the pod deletion policy reconciliation path for pods stranded on down nodes.

  • maps StatefulSet child Pod events back to the owning Tenant through the RustFS tenant label, instead of relying on direct Tenant ownership
  • requeues not-ready Tenants with pod deletion policy enabled so later fencing changes can be observed even without a Tenant spec/status event
  • requires Deployment policies to prove the full Pod -> ReplicaSet -> Deployment -> Tenant owner UID chain before cleanup
  • emits a Warning event when force deletion is skipped because the node has not been fenced
  • clarifies Delete versus force-delete semantics in API docs, generated CRDs, and user guides

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit (fmt-check + clippy + test + console-lint + console-fmt-check)
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CHANGELOG.md updated under [Unreleased] (if user-visible change) - N/A: this repository currently has no CHANGELOG.md
  • CI/CD passed (if applicable) - N/A: pending upstream CI after PR creation

Impact

  • Breaking change (CRD/API compatibility)
  • Requires doc/config/deployment update
  • Other impact:

Verification

make pre-commit

Additional Notes

Opened as a draft PR for maintainer review.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@GatewayJ GatewayJ marked this pull request as ready for review July 11, 2026 13:01
@GatewayJ GatewayJ added this pull request to the merge queue Jul 11, 2026
Merged via the queue into rustfs:main with commit 99d299f Jul 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pod Deletion Policy When Node is Down

1 participant