Fix nginx websocket and keepalive support #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default nginx will send a `Connection: close` request header to the upstream when proxying which breaks upstream connection keepalives and can introduce latency due to repeated upstream TCP handshakes, and port exhaustion under load due to accumulating `TIME_WAIT`/`CLOSE_WAIT` TCP sockets. To fix upstream keepalives we configure nginx to not send the `Connection` request header upstream by setting the value to blank. However, for websocket support, if the `Upgrade: websocket` request header is present, we must send a `Connection: upgrade` request header with it to the upstream. An nginx `map` allows us to support both within the same `location` block.
|
@jstangroome is attempting to deploy a commit to the overtrue's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default nginx will send a
Connection: closerequest header to the upstream when proxying which breaks upstream connection keepalives and can introduce latency due to repeated upstream TCP handshakes, and port exhaustion under load due to accumulatingTIME_WAIT/CLOSE_WAITTCP sockets.To fix upstream keepalives we configure nginx to not send the
Connectionrequest header upstream by setting the value to blank.However, for websocket support, if the
Upgrade: websocketrequest header is present, we must send aConnection: upgraderequest header with it to the upstream.An nginx
mapallows us to support both within the samelocationblock.