feat(phase-2): add jq and yq to rc docker image#44
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds commonly requested JSON/YAML tooling to the rustfs/rc runtime container image and introduces a contract test to prevent those tools from being removed unintentionally in future Dockerfile edits (closes #43).
Changes:
- Install
jqandyqin the Docker runtime stage viaapk add. - Add a CLI integration test that inspects the root
Dockerfileto enforce presence ofjq/yqin the runtime package install.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Dockerfile |
Adds jq and yq to the runtime-stage apk add invocation. |
crates/cli/tests/dockerfile_runtime_tools.rs |
Adds a contract test to detect regressions in runtime-tool availability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jqandyqin the runtime stage of the Docker imagejq/yqpresence in the runtimeapk addlineIssue
Closes #43
Root Cause
The runtime image only installed
ca-certificates, sojqandyqwere unavailable inrustfs/rc:latestcontainers.Verification
Reproduction (before fix, published latest image)
docker run --rm --entrypoint sh rustfs/rc:latest -lc 'command -v jq >/dev/null 2>&1 || echo jq-missing; command -v yq >/dev/null 2>&1 || echo yq-missing'Observed:
jq-missingyq-missingAfter fix (branch image)
Observed:
jq-1.8.1yq ... v4.49.2Quality gates
cargo fmt --allcargo clippy --workspace -- -D warningscargo test --workspaceAll passed.
Additional scan for similar issues
Searched for other runtime package install points and related Docker image definitions; no additional missing
jq/yqinstallation locations were found.