feat: add anonymous bucket access commands#42
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an anonymous command group to the CLI to manage anonymous bucket/object access (mc-compatible), backed by new ObjectStore bucket policy APIs implemented for the S3 client.
Changes:
- Introduces
rc anonymous {set,set-json,get,get-json,list,links}and wires it into the CLI parser/executor. - Extends
ObjectStorewithget_bucket_policy/set_bucket_policy/delete_bucket_policyand addsCapabilities::anonymous. - Implements S3 bucket policy operations with “missing policy” compatibility handling and updates CLI help-contract tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/s3/src/client.rs | Adds Capabilities::anonymous and implements bucket policy get/set/delete on S3 client. |
| crates/core/src/traits.rs | Extends Capabilities and ObjectStore with anonymous/policy support. |
| crates/cli/src/commands/anonymous.rs | New CLI module implementing anonymous access workflows (set/get/list/links). |
| crates/cli/src/commands/mod.rs | Registers the new anonymous top-level command and execution routing. |
| crates/cli/tests/help_contract.rs | Updates help-contract expectations for anonymous and its subcommands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anonymoustop-level command and subcommands (set,set-json,get,get-json,list,links) in CLIObjectStorewith bucket policy interfaces:get_bucket_policy,set_bucket_policy,delete_bucket_policyImplementation details
Verification
cargo check -p rustfs-clicargo test -p rustfs-cli help_contract -- --nocapturerustfs/rustfs:latestforanonymous set/get/list/links/get-json/set-jsonand anonymous read/write behavior