Lower minimum Rust version from 1.92 to 1.91#18
Conversation
Co-authored-by: overtrue <1472352+overtrue@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request lowers the minimum supported Rust version (MSRV) from 1.92 to 1.88 to enable building the CLI alongside rustfs in Alpine 3.23-based Docker images, which ship with Rust 1.91. The change aligns the declared MSRV with the actual constraint imposed by the AWS SDK dependencies (aws-sdk-s3, aws-config, etc.), which require Rust 1.88.
Changes:
- Updated
rust-versionin workspaceCargo.tomlfrom "1.92" to "1.88"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Cargo.toml
Outdated
| version = "0.1.3" | ||
| edition = "2024" | ||
| rust-version = "1.92" | ||
| rust-version = "1.88" |
There was a problem hiding this comment.
The MSRV has been updated to 1.88 in Cargo.toml, but several other files still reference the old 1.92 version and need to be updated for consistency:
.github/workflows/ci.ymlline 119 - The MSRV CI job still uses toolchain "1.92"Dockerfileline 1 - Usesrust:1.92.0-alpine3.23base imageREADME.mdline 293 - Documents "Rust 1.92 or higher"CHANGELOG.mdline 25 - States "Updated minimum supported Rust version (MSRV) to 1.92"
All these references should be updated to 1.88 to match this change. The inconsistency could cause CI failures and confusion for users.
Co-authored-by: overtrue <1472352+overtrue@users.noreply.github.com>
Alpine 3.23 ships Rust 1.91, making it impossible to build the CLI alongside rustfs in a single custom image given the
rust-version = "1.92"floor.Changes
Cargo.toml: Droprust-versionfrom1.92→1.91This matches exactly the Rust version shipped with Alpine 3.23, which is the target environment. All dependencies require at most Rust 1.88, so 1.91 satisfies every constraint while accurately reflecting the minimum tested and supported version.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.