Conversation
I think it's just that You did not actually include |
I think this is the right thing to do here, but I'm not entirely sure.
|
I wrote all that out about it and forgot to actually require |
I think it's just that You did not actually include |
I think this is the right thing to do here, but I'm not entirely sure.
|
I wrote all that out about it and forgot to actually require |
Working with numerics in
num-traitsis biased towards using the standard traits, which is generally good. However, checked arithmetic is lacking a unifying trait (likeNumOps). This PR adds that.This trait should theoretically be a supertrait of
PrimInt. However, this trait (likeNumOps: Rem), requiresCheckedRem.PrimIntdoes not currently require that, meaning that this would be a breaking change. (PrimInt: CheckedNumOpsfor a future release?)