Skip to content

Revert "input: Replace open-coded types with ndk::event definitions (#163)"#218

Merged
rib merged 1 commit intomainfrom
rib/pr/revert-pr163
Feb 17, 2026
Merged

Revert "input: Replace open-coded types with ndk::event definitions (#163)"#218
rib merged 1 commit intomainfrom
rib/pr/revert-pr163

Conversation

@rib
Copy link
Member

@rib rib commented Feb 17, 2026

This reverts commit 51d05d4 for backwards compatibility with the existing 0.6 releases.

For now, it's creating a lot of busy work having to always make this revert in order to test various topic branch changes with winit 0.30.

Lets save this breaking change until we have more reasons to break semver compatibility (in itself this doesn't fix or enable any features, so we can live without it for now).

…#163)"

This reverts commit 51d05d4 for
backwards compatibility with the existing `0.6` releases.

For now, it's creating a lot of busy work having to always make this
revert in order to test various topic branch changes with winit 0.30.

Lets save this breaking change until we have more reasons to break
semver compatibility (in itself this doesn't fix or enable any features,
so we can live without it for now).
@MarijnS95
Copy link
Member

We already reverted this on the 0.6 "stable release" or "backports" branch, no need for duplication: https://github.com/rust-mobile/android-activity/commits/release-0.6.

@MarijnS95 MarijnS95 closed this Feb 17, 2026
@rib
Copy link
Member Author

rib commented Feb 17, 2026

We already reverted this on the 0.6 "stable release" or "backports" branch, no need for duplication: https://github.com/rust-mobile/android-activity/commits/release-0.6.

Yeah - although we had discussed maintaining a release-0.6 branch; I'm finding that this change is creating extra steps while I'd like to look at testing and landing the jni 0.22 and TextAction changes.

I think it's awkward currently that I can't properly test changes against main, since the main use case I tend to care about is testing with winit 0.30.

I can maintain topic branches based on release-0.6 with this reverted and then cherry pick before opening a PR against main but I really don't like the fact that main then is not the thing that's really getting tested.

I also don't want the extra steps of merging or cherry picking changes back to the release 0.6 branch at this stage. The extra steps just don't feel worth it right now compared to reverting this and waiting until we have a stronger reason to break backwards compatibility.

The change itself should be pretty easy to re-apply later when we have other breaking changes to make - and less work overall.

@rib rib reopened this Feb 17, 2026
@rib rib merged commit 0b0e19e into main Feb 17, 2026
10 checks passed
@rib rib deleted the rib/pr/revert-pr163 branch February 17, 2026 21:43
@MarijnS95
Copy link
Member

Whatever suits you. I've anyway moved over to my own fork and rewrite of ndk-glue with multi-activity support, some buggy assumptions we've ignored for far too long.

I don't intend on doing anything here anyway anymore and am inclined to drop my permissions from rust-mobile to signify my lack of interest and resulting liberation of responsibilities.

@rib
Copy link
Member Author

rib commented Feb 17, 2026

sorry you feel that way.

fwiw, the revert isn't intended to be a rejection of the change - I would expect to land it again - but I have a hand full of topic branches I've been working on and in practice I've been finding it painful to be testing and moving work back and forth between branches with and without this breaking change.

I've been spending a lot of time trying to get the jni 0.22 release out the door and now that's done, I'd like to catch up on some of the changes here and I essentially just want to temporarily avoid this paper cut with moving changes around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments