fix(diskio): fall back to single-threaded unpacking #4717
Merged
rami3l merged 1 commit intorust-lang:mainfrom Feb 17, 2026
Merged
fix(diskio): fall back to single-threaded unpacking #4717rami3l merged 1 commit intorust-lang:mainfrom
rami3l merged 1 commit intorust-lang:mainfrom
Conversation
cachebag
force-pushed
the
main
branch
2 times, most recently
from
d5589b7 to
d1fa4f5
Compare
djc
approved these changes
Feb 16, 2026
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Nice, this makes sense to me!
cachebag
force-pushed
the
main
branch
2 times, most recently
from
cc79dba to
08bc04a
Compare
rami3l
reviewed
Feb 16, 2026
cachebag
force-pushed
the
main
branch
3 times, most recently
from
f4b6496 to
fefd937
Compare
rami3l
approved these changes
Feb 16, 2026
Member
rami3l
left a comment
rami3l
left a comment
There was a problem hiding this comment.
LGTM modulo one final nit (my apologies for the back and forth), and thanks again for your contribution :)
… < 512MB to avoid OOM on memory-constrained systems Rustup OOMs on systems with <1GB RAM because it spawns multiple I/O threads for unpacking regardless of available memory. The Threaded executor uses far more memory than its buffer pool budget tracks. This PR adds a 512MB ram_budget threshold below which rustup falls back to single-threaded unpacking, which peaks at ~110MB. Fixes rust-lang#3125
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ram_budget< 512MB, fall back to single-threaded unpacking to avoid OOM on memory-constrained systems.Rustup OOMs on systems with <1GB RAM because it spawns multiple I/O threads for unpacking regardless of available memory. The Threaded executor uses far more memory than its buffer pool budget tracks. This PR adds a 512MB
ram_budgetthreshold below which rustup falls back to single-threaded unpacking, which peaks at ~110MB.Fixes #3125