fix(dist/manifest): sort keys when serializing Manifest#4716
Merged
rami3l merged 1 commit intorust-lang:mainfrom Feb 15, 2026
Merged
fix(dist/manifest): sort keys when serializing Manifest#4716rami3l merged 1 commit intorust-lang:mainfrom
Manifest#4716rami3l merged 1 commit intorust-lang:mainfrom
Conversation
rami3l
force-pushed
the
fix/manifest-serialization-order
branch
from
55adbb1 to
f9c4532
Compare
djc
approved these changes
Feb 14, 2026
rami3l
force-pushed
the
fix/manifest-serialization-order
branch
from
f9c4532 to
f85dadf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4715.
This is a quick and dirty fix by manually replacing all
HashMapreferences withBTreeMapwhen relevant. An additional regression test has been added as well to demonstrate the establishment of what we hope to be the canonical form for the manifest file saved on the disk.Many thanks again for @loynoir's report and pointers.