Rename splat attribute to rustc_splat - #93
Open
teor2345 wants to merge 2 commits into
Open
Conversation
jieyouxu
approved these changes
Jul 31, 2026
jieyouxu
left a comment
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks! This looks good, though I'd wait for someone more familiar with the name mangling to take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
This is part of a fix for a name resolution clash in rustc, see rust-lang/rust#159428. The rustc fix is in rust-lang/rust#159817.
This mangling PR doesn't need to be backported, because the beta branch was before we added demangling.