Skip to content

doc: document safety requirements for core WTF-8 - #161271

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yilin0518:fix_coree_wtf8
Aug 21, 2026
Merged

doc: document safety requirements for core WTF-8#161271
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yilin0518:fix_coree_wtf8

Conversation

@yilin0518

@yilin0518 yilin0518 commented Aug 18, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

This PR is a follow-up to #160824, and serves as a complementry of Wtf8 in alloc . This PR currently fixes the wtf8 module in core, because I noticed that some unsafe APIs in this file do not provide a safety section. Therefore, before discharging the call sites, we need to first add the safety section. This PR performs that fix.

This PR is related to unstable feature Wtf8 but this feature don't have relevant tracking issue.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 18, 2026
@rustbot

rustbot commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e, tgross35

@yilin0518 yilin0518 mentioned this pull request Aug 18, 2026
Merged
@clarfonthey

clarfonthey commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Thank you!

@rust-bors

rust-bors Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c215bed has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161271 - yilin0518:fix_coree_wtf8, r=clarfo…
c595c4a 
…nthey

doc: document safety requirements for core WTF-8

This PR is a follow-up to rust-lang#160824, and serves as a complementry of `Wtf8` in `alloc` . This PR currently fixes the wtf8 module in `core`, because I noticed that some unsafe APIs in this file do not provide a `safety section`. Therefore, before discharging the call sites, we need to first add the safety section. This PR performs that fix.

This PR is related to unstable feature `Wtf8` but this feature don't have relevant tracking issue.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161271 - yilin0518:fix_coree_wtf8, r=clarfo…
c1fb37e 
…nthey

doc: document safety requirements for core WTF-8

This PR is a follow-up to rust-lang#160824, and serves as a complementry of `Wtf8` in `alloc` . This PR currently fixes the wtf8 module in `core`, because I noticed that some unsafe APIs in this file do not provide a `safety section`. Therefore, before discharging the call sites, we need to first add the safety section. This PR performs that fix.

This PR is related to unstable feature `Wtf8` but this feature don't have relevant tracking issue.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 21, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161455 - JonathanBrouwer:rollup-hQbbeP7, r=JonathanBro…
aeca481 
…uwer

Rollup of 16 pull requests

Successful merges:

 - #161259 (move some attribute related structs out of rustc_attr_ir)
 - #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - #159899 ( `GenericArgs::types` triage + possible fixes)
 - #160459 (Use attribute parser for `deprecated` attribute checking)
 - #160813 (Optimize linked list iterator performance)
 - #161271 (doc: document safety requirements for core WTF-8)
 - #161317 (LLVM 24: configure float-abi via module flag)
 - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - #161369 (Add regression test for confusing lifetime error message issue)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
 - #161438 (Change triagebot backport to ping T-libs-fcp)
 - #161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@jhpratt jhpratt mentioned this pull request Aug 21, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
a872286 
Rollup of 20 pull requests

Successful merges:

 - #161259 (move some attribute related structs out of rustc_attr_ir)
 - #160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - #161161 (proc_macro: add support for 16-bit targets)
 - #159899 ( `GenericArgs::types` triage + possible fixes)
 - #160459 (Use attribute parser for `deprecated` attribute checking)
 - #160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - #160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - #160595 (Clarify `str::split_at` docs)
 - #160813 (Optimize linked list iterator performance)
 - #161271 (doc: document safety requirements for core WTF-8)
 - #161317 (LLVM 24: configure float-abi via module flag)
 - #161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - #161369 (Add regression test for confusing lifetime error message issue)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
 - #161438 (Change triagebot backport to ping T-libs-fcp)
 - #161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
@rust-bors
rust-bors Bot merged commit f7e9665 into rust-lang:main Aug 21, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 21, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 21, 2026
@bors
Unrolled build for #161271 in rollup 161458
b5fd21b 
Rollup merge of #161271 - yilin0518:fix_coree_wtf8, r=clarfonthey

doc: document safety requirements for core WTF-8

This PR is a follow-up to #160824, and serves as a complementry of `Wtf8` in `alloc` . This PR currently fixes the wtf8 module in `core`, because I noticed that some unsafe APIs in this file do not provide a `safety section`. Therefore, before discharging the call sites, we need to first add the safety section. This PR performs that fix.

This PR is related to unstable feature `Wtf8` but this feature don't have relevant tracking issue.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
1462014 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
97f9954 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
16902ce 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
c042576 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 22, 2026
@jhpratt
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
4a3eebe 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
cb113ef 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
2ab789f 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161292 - yilin0518:fix_alloc_wtf8, r=clarfo…
0d32bcb 
…nthey

Add safety comments in alloc::Wtf8

This PR follow up rust-lang#160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in rust-lang#160824.

Before this PR, rust-lang#161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
rust-bors Bot pushed a commit that referenced this pull request Aug 22, 2026
@bors
Unrolled build for #161292 in rollup 161505
429a71b 
Rollup merge of #161292 - yilin0518:fix_alloc_wtf8, r=clarfonthey

Add safety comments in alloc::Wtf8

This PR follow up #160824 and add some safety section for unsafe APIs. This PR focus on Wtf8 in alloc and fix every `Untriged` mentioned in #160824.

Before this PR, #161271 had add some safety sections for Wtf8 in core.

I'm looking forward to your review and give me any feedback to improve this PR.
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Aug 22, 2026
@bors
Auto merge of #161458 - jhpratt:rollup-q1wVzyt, r=jhpratt
b4454c1 
Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#161259 (move some attribute related structs out of rustc_attr_ir)
 - rust-lang/rust#160853 (delegation: simplify matches on `FnKind`, minor refactorings)
 - rust-lang/rust#161161 (proc_macro: add support for 16-bit targets)
 - rust-lang/rust#159899 ( `GenericArgs::types` triage + possible fixes)
 - rust-lang/rust#160459 (Use attribute parser for `deprecated` attribute checking)
 - rust-lang/rust#160536 (Inline `String::into_raw_parts` and reuse `from_utf16` optimization)
 - rust-lang/rust#160563 (Make `BorrowedCursor<'a, T>` covariant in `'a` and drop an indirection)
 - rust-lang/rust#160595 (Clarify `str::split_at` docs)
 - rust-lang/rust#160813 (Optimize linked list iterator performance)
 - rust-lang/rust#161271 (doc: document safety requirements for core WTF-8)
 - rust-lang/rust#161317 (LLVM 24: configure float-abi via module flag)
 - rust-lang/rust#161320 (Only suggest `RUST_MIN_STACK` if maybe stack overflow)
 - rust-lang/rust#161369 (Add regression test for confusing lifetime error message issue)
 - rust-lang/rust#161393 (Configure LLM policy URL for triagebot)
 - rust-lang/rust#161403 (splat-fn-ptr-ptr-tuple.rs: add `let` to avoid UB)
 - rust-lang/rust#161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - rust-lang/rust#161410 (Fix rustdoc remapping `documentation` scope documentation)
 - rust-lang/rust#161415 (Update expect messages in path docs to better follow guidelines)
 - rust-lang/rust#161438 (Change triagebot backport to ping T-libs-fcp)
 - rust-lang/rust#161442 (Add regression test for dead code on type alias used in impl self type)

Failed merges:

 - rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@clarfonthey clarfonthey

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yilin0518 @rustbot @clarfonthey