Tweak error for stmt macro expansion in expression context - #161035
Open
estebank wants to merge 1 commit into
Open
Tweak error for stmt macro expansion in expression context#161035estebank wants to merge 1 commit into
estebank wants to merge 1 commit into
Conversation
- Use a multipart suggestion - When encountering a `stmt` metavariable where an expression is expected in another macro expansion, do not suggest a stray `;`
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
estebank
changed the title
estebank
commented
Aug 13, 2026
Comment on lines
+12
to
+15
| help: surround the macro invocation with `{}` to interpret the expansion as a statement | ||
| | | ||
| LL | println!("{}", { foo!(42); }); | ||
| | + +++ |
Contributor
Author
There was a problem hiding this comment.
I am not 100% sure that we want to provide this suggestion. It is valid in that it produces syntactically correct code, but then the resulting () will likely be completely useless for the println.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stmtmetavariable where an expression is expected in another macro expansion, do not suggest a stray;Fix #30597.