Library: enforce clippy deref lints in CI

[ChrisDenton]

Best reviewed commit by commit.

The output is from clippy --fix but I've reviewed the changes and am feeling confident there are no behaviour changes. Still, a second pair of eyes would be useful.

[rustbot]

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: libs
• libs expanded to 12 candidates
• Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

[clarfonthey]

For reference, the included lints are:

• needless_borrow
• op_ref
• borrow_deref_ref
• explicit_auto_deref

[clarfonthey]

Also fwiw I did review this and agree it looks like everything is fine, although figure we probably want someone who isn't as enthusiastic about enabling clippy lints everywhere to take a look and make sure we're not being overzealous. So, I'll let someone else perform that aspect of "review" rather than just merging this.

[ChrisDenton]

Let my try a few platforms to catch any platform-specific code that hits these lints. I'm not entirely sure which ones actually use clippy in CI so I'll just try a selection:

@bors try jobs=arm-android,i686-gnu-,test-various,x86_64-gnu,aarch64-apple-,x86_64-msvc-,i686-msvc-,x86_64-mingw-*

[nia-e]

i handled the last one, so i'm happy lightening the review load ^^

r? me

[rust-bors]

💔 Test for b0329c8 failed: CI. Failed job:

• try - x86_64-msvc-1 (web logs, enhanced plaintext logs)

[ChrisDenton]

Hm, the logs just aren't there. Weird. Let me try again

@bors try jobs=x86_64-msvc-1

[rust-bors]

⌛ Trying commit 7f74e59 with merge d8e77f5…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/31695315900