Skip to content

[CI] Build newer binutils before building gcc - #161006

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:gcc-binutils
Open

[CI] Build newer binutils before building gcc#161006
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:gcc-binutils

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Hopefully will unblock the GCC sync. This PR builds a newer binutils, unlocking all blocked gcc features that we need.

Needs rust-lang/ci-mirrors#55 to be merged first.

r? @Kobzol

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 12, 2026
@rustbot

rustbot commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol

Kobzol commented Aug 13, 2026

Copy link
Copy Markdown
Member

Let's try.

@bors try

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
[CI] Build newer `binutils` before building `gcc`
@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 19e8ca2 (19e8ca2034dca990b6050645ed555e504708ad7b)
Base parent: 79ef636 (79ef636a60b0f5ca061b09122bbbca3c7b4a3b70)

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

That's good news. =D

--prefix=/rustroot \
--enable-languages=c,c++ \
--disable-gnu-unique-object \
--enable-cxx-flags='-fno-reorder-blocks-and-partition'

@antoyo antoyo Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need --with-as= and --with-ld= or is it not necessary since you do make install above?

View changes since the review

# '-fno-reorder-blocks-and-partition' is required to
# enable BOLT optimization of the C++ standard library,
# which is included in librustc_driver.so
hide_output ../gcc-$GCC/configure \

@antoyo antoyo Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth temporarily removing hide_output in order to see whether it does the good thing and find that the retain attribute is supported?
Is there any better way we could double-check that everything is good now?

View changes since the review

@Kobzol

Kobzol commented Aug 13, 2026

Copy link
Copy Markdown
Member

We need the full build, I didn't realize that.

@bors try jobs=dist-x86_64-linux

@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit 377ef9f with merge 91816c5

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/31697658273

rust-bors Bot pushed a commit that referenced this pull request Aug 13, 2026
[CI] Build newer `binutils` before building `gcc`


try-job: dist-x86_64-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants